Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the PWA link point to the right place #8379

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Make the PWA link point to the right place #8379

merged 1 commit into from
Jan 31, 2020

Conversation

cassidoo
Copy link
Contributor

Currently, the https://bit.ly/CRA-PWA link points to this README, which points to another document, which points to this page.

This change puts a link to this page in the README to save folks an extra click.

@facebook-github-bot
Copy link

Hi cassidoo! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this has bothered me for a while too! Can we change this to https://create-react-app.dev/docs/making-a-progressive-web-app/ to remove one more redirection?

@cassidoo
Copy link
Contributor Author

Nice, this has bothered me for a while too! Can we change this to https://create-react-app.dev/docs/making-a-progressive-web-app/ to remove one more redirection?

I wanted to do that, but after looking at the current issues it looks like the React team prefers a bit.ly link that they can change around, so this way at least it saves some headache until someone does that internally.

@mrmckeb
Copy link
Contributor

mrmckeb commented Jan 28, 2020

Thanks @cassidoo, I think we can merge for now @petetnt - I can see the change has been made, and we'll have to look at all of these in the next months as we move towards the new URL shortener @iansu is looking at.

By the way, my Twitter feed is constantly full of your videos @cassidoo! Keep up the great work.

@andriijas andriijas modified the milestones: 3.x, 3.4 Jan 31, 2020
@andriijas andriijas merged commit fb9745e into facebook:master Jan 31, 2020
@cassidoo cassidoo deleted the patch-1 branch January 31, 2020 08:33
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants