Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(env): stringified with descriptive keys #8389

Closed
wants to merge 1 commit into from

Conversation

AbraaoAlves
Copy link

Related #6642

Sometimes when some env var isn't defined, the minified version is sent with a lot of extra information. It's happening because webpack.DefinePlugin expect a descriptive key for each field

Note

Analyze the impact of overwriting process.env object on the bundle.

@facebook-github-bot
Copy link

Hi AbraaoAlves! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@stale
Copy link

stale bot commented Feb 28, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 28, 2020
@stale
Copy link

stale bot commented Mar 4, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants