Return correct package name when using a custom react-script scoped package #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
getPackageName
method returns an empty string when attempting to use a custom react-scripts package that's a scoped package (e.g.create-react-app my-test-app --scripts-version=@dpoineau/react-scripts
), which causes the final step ofcreate-react-app
to fail.This slightly tweaks the condition so that it will work correctly with scoped packages too.