Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps pnp-webpack-plugin #8509

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Bumps pnp-webpack-plugin #8509

merged 2 commits into from
Feb 19, 2020

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Feb 18, 2020

Since the PnP instance was stored in a global closure, a refreshed instance (when a dependency was added or removed) wasn't being being picked up. I fixed it in the plugin, now updating the dependency 😃

Fixes yarnpkg/berry#958

@ianschmitz ianschmitz added this to the 3.4.1 milestone Feb 19, 2020
@ianschmitz
Copy link
Contributor

Thanks @arcanis!

@ianschmitz ianschmitz merged commit af926d5 into facebook:master Feb 19, 2020
@lock lock bot locked and limited conversation to collaborators Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Module Not Found on Create-React-App
3 participants