Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React.StrictMode to default templates #8558

Merged
merged 5 commits into from
Mar 10, 2020

Conversation

connkat
Copy link
Contributor

@connkat connkat commented Feb 26, 2020

Added in <React.StrictMode> tags to the default templates.

Closes #8557

Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these into the index file and wrap the rendering of App there. Also it looks like Prettier wasn't run on commit.

@mrmckeb
Copy link
Contributor

mrmckeb commented Feb 29, 2020

@connkat let us know if you need any help with that change.

@ianschmitz
Copy link
Contributor

@connkat are you able to update the PR with the suggestions? If not no worries we can get 'er fixed up!

@connkat
Copy link
Contributor Author

connkat commented Mar 5, 2020

@ianschmitz I can totally get this done by the weekend! Got distracted with some other things IRL but should have the PR up by Sat.

@connkat connkat requested a review from ianschmitz March 7, 2020 19:09
@gaearon
Copy link
Contributor

gaearon commented Mar 8, 2020

Thank you @connkat! I made a few small changes — looks like you forgot to revert the changes in App.js. I think this is good to go now but I'll defer to @ianschmitz to merge.

@ianschmitz ianschmitz changed the title added strictmode tags to default templates Add React.StrictMode to default templates Mar 8, 2020
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @connkat - @ianschmitz I think this is good to go.

@ianschmitz
Copy link
Contributor

I'm just working on fixing CI in master.

@ianschmitz ianschmitz closed this Mar 9, 2020
@ianschmitz ianschmitz reopened this Mar 9, 2020
@ianschmitz ianschmitz merged commit 6adb82a into facebook:master Mar 10, 2020
@ianschmitz
Copy link
Contributor

Thanks!

@lock lock bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap in StrictMode by default
5 participants