Exit production build if any errors are in build stats #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
suggested changes
Oct 7, 2016
| @@ -128,6 +128,13 @@ function build(previousSizeMap) { | |||
| process.exit(1); | |||
| } | |||
|
|
|||
| // Webpack may swallow uglify errors even with bail:true | |||
| if (stats.compilation.errors.length) { | |||
| console.error(chalk.red('Error(s) occurred during the production build:')); | |||
There was a problem hiding this comment.
Can this be the same message that we use for failed compilation in start.js? And would be nice to fix it up for the other (different) message in this file so they are all consistent.
gaearon
approved these changes
Oct 7, 2016
|
Thanks! |
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Exit on any errors passed in build stats * Match console error output in start.js
jarlef
pushed a commit
to jarlef/create-react-app
that referenced
this pull request
Nov 28, 2016
* Exit on any errors passed in build stats * Match console error output in start.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until webpack/webpack#2390 is addressed and all errors trigger the
--bailswitch, would be helpful to manually surface them from the production build stats passed in the callback.Sample output