Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate transform-regenerator dependency #864

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

akofman
Copy link
Contributor

@akofman akofman commented Oct 6, 2016

It looks like babel-plugin-transform-regenerator is already a dependency of babel-preset-es2015 in a different version :

$npm ls babel-plugin-transform-regenerator 
babel-preset-react-app@0.2.1 
├── babel-plugin-transform-regenerator@6.14.0
└─┬ babel-preset-latest@6.14.0
  └─┬ babel-preset-es2015@6.16.0
    └── babel-plugin-transform-regenerator@6.16.1

This can causes some trouble when using regeneratorRuntime but to ensure the older npm compatibility we have to keep this dependency.
So I just updated its version to the same version found from babel-preset-es2015@6.16.0.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit ad57c45 into facebook:master Oct 7, 2016
@fson fson added this to the 0.7.0 milestone Oct 12, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants