Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving npmrc #8828

Closed
wants to merge 34 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
d53902b
setting up package.json to fork, adding in babel plugin
nicolechung Jul 22, 2019
5384c01
adding babel plugin styled components
nicolechung Jul 22, 2019
9367ae2
babel plugin styled components only
nicolechung Jul 24, 2019
71cd54a
adding npm module name for league-web
nicolechung Jul 24, 2019
dc67877
[League-web] - babel-plugin-styled-components
nicolechung Jul 24, 2019
47d77ae
changing org name to publish
nicolechung Jul 24, 2019
c84566b
adding private is false flag to publish
nicolechung Jul 25, 2019
171eb1e
changing tag
nicolechung Jul 25, 2019
ae7c268
removing the tag from the repository url
nicolechung Jul 25, 2019
d62a780
Merging league changes to master
nicolechung Jul 25, 2019
fd91ca7
changing semver to be in line with actual react-scripts
nicolechung Jul 26, 2019
bd66974
changing semver to be in line with actual react-scripts
nicolechung Jul 26, 2019
addf8a2
Merge remote-tracking branch 'upstream/master'
theinterned Jan 13, 2020
9ed30b8
Merge tag 'v3.3.1'
theinterned Feb 6, 2020
a25a08e
Adds hack to include Object.entries pollyfill for all builds
theinterned Feb 7, 2020
8d3eb4c
update pkg.version to 3.3.1-pr9 to match this PR number
theinterned Feb 7, 2020
be01d50
Merge pull request #9 from EverlongProject/FRONTEND-99-Web-Bump-CRA-f…
theinterned Feb 7, 2020
30f8ab1
Merge tag 'v3.4.0'
stefankram Feb 27, 2020
568f38e
Removed the fix in webpack config for IE11
stefankram Feb 28, 2020
2aafd68
Merge pull request #15 from stefankram/FRONTEND-100
stefankram Feb 28, 2020
d513cff
circle config
nicolechung Mar 18, 2020
387af92
Publish to everlong registry
nicolechung Mar 18, 2020
44bdaf3
Merge tag 'v.3.4.1'
nicolechung Apr 9, 2020
006ae46
trying this a third time
nicolechung Apr 9, 2020
5b8f1f7
Yaml fix for publishing to private registry
nicolechung Apr 13, 2020
9e6fa97
adding yarn publish command
nicolechung Apr 13, 2020
7ee7129
using cat
nicolechung Apr 13, 2020
03301c1
changing variable back, it should be the file path
nicolechung Apr 13, 2020
bf927be
adding yarn publish command
nicolechung Apr 13, 2020
acf227f
adding npmrc
nicolechung Apr 13, 2020
5133c28
adding npmrc
nicolechung Apr 13, 2020
99c942c
publishing workspace
nicolechung Apr 13, 2020
23aa5e4
publish_workspace
nicolechung Apr 13, 2020
3e4df9a
moving npmrc
nicolechung Apr 13, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
defaults: &defaults
docker:
- image: circleci/node:10.16

aliases:
- &restore_npm
restore_cache:
keys:
- cra-npm-{{ checksum "yarn.lock" }}
- &save_npm
save_cache:
paths:
- ./node_modules
- ./packages/*/node_modules
key: genesis-npm-{{ checksum "yarn.lock" }}
- &yarn_install
run: yarn install --frozen-lockfile

version: 2.1
jobs:
publish-package:
<<: *defaults
steps:
- checkout
- *restore_npm
- *yarn_install
- *save_npm
- run: yarn publish-package

workflows:
version: 2.1
publish_to_private_registry:
jobs:
- publish-package:
filters:
branches:
ignore: /.*/
tags:
only: /^v\d+\.\d+\.\d+(\.[a-zA-Z]+)?/
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ labels: 'issue: bug report, needs triage'

(Write your steps here:)

1.
2.
3.
1. 2. 3.

### Expected behavior

Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"alex": "alex .",
"test": "cd packages/react-scripts && node bin/react-scripts.js test",
"format": "prettier --trailing-comma es5 --single-quote --write 'packages/*/*.js' 'packages/*/!(node_modules)/**/*.js'",
"compile:lockfile": "node tasks/compile-lockfile.js"
"compile:lockfile": "node tasks/compile-lockfile.js",
"publish-package": "yarn workspace @everlong/league-react-scripts publish-package"
},
"devDependencies": {
"@testing-library/jest-dom": "^4.2.0",
Expand Down
5 changes: 5 additions & 0 deletions packages/react-scripts/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
@everlong:registry=https://us-central1-npm.pkg.dev/uplifted-triode-608/npm/
//us-central1-npm.pkg.dev/uplifted-triode-608/npm/:_password=""
//us-central1-npm.pkg.dev/uplifted-triode-608/npm/:username=oauth2accesstoken
//us-central1-npm.pkg.dev/uplifted-triode-608/npm/:email=not.valid@email.com
//us-central1-npm.pkg.dev/uplifted-triode-608/npm/:always-auth=true
10 changes: 10 additions & 0 deletions packages/react-scripts/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,16 @@ module.exports = function(webpackEnv) {
},
},
],
// START: EVERLONG CHANGES
[
require.resolve('babel-plugin-styled-components'),
{
fileName: false,
preprocess: false,
displayName: true,
},
],
// END: EVERLONG CHANGES
],
// This is a feature of `babel-loader` for webpack (not Babel itself).
// It enables caching results in ./node_modules/.cache/babel-loader/
Expand Down
13 changes: 9 additions & 4 deletions packages/react-scripts/package.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
{
"name": "react-scripts",
"name": "@everlong/league-react-scripts",
"version": "3.4.1",
"description": "Configuration and scripts for Create React App.",
"description": "Everlong configuration and scripts for Create React App.",
"repository": {
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"url": "git@github.com:EverlongProject/create-react-app.git",
"directory": "packages/react-scripts"
},
"private": false,
"license": "MIT",
"engines": {
"node": ">=8.10"
},
"bugs": {
"url": "https://github.com/facebook/create-react-app/issues"
"url": "git@github.com:EverlongProject/create-react-app/issues"
},
"files": [
"bin",
Expand All @@ -23,6 +24,9 @@
"template-typescript",
"utils"
],
"scripts": {
"publish-package": "echo $GOOGLE_AUTH_B64 | base64 --decode > .google_creds && GOOGLE_APPLICATION_CREDENTIALS=.google_creds npx google-artifactregistry-auth .npmrc && rm -f .google_creds && yarn publish"
},
"bin": {
"react-scripts": "./bin/react-scripts.js"
},
Expand All @@ -32,6 +36,7 @@
"@svgr/webpack": "4.3.3",
"@typescript-eslint/eslint-plugin": "^2.10.0",
"@typescript-eslint/parser": "^2.10.0",
"babel-plugin-styled-components": "1.10.6",
"babel-eslint": "10.1.0",
"babel-jest": "^24.9.0",
"babel-loader": "8.1.0",
Expand Down