[#8829] Ensure all build errors are retained for logging when a build fails #8831
Conversation
tSchubes
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @tSchubes! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
Fixes #8829 by removing the error truncation and leaving the full error list intact.
Very little to verify here as it's a simple change which impacts only the error reporting process. Verified by wrecking the hell out of my source code and viewing the various errors in all their glory before repairing and building successfully.