Fix type for PUBLIC_URL in cra-template-typescript #8852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeromeDeLeon
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
casaub0n
added a commit
to casaub0n/casaub0n-gh
that referenced
this pull request
Apr 18, 2020
I followed this PR that's [Fix type for PUBLIC_URL in cra-template-typescript by JeromeDeLeon · Pull Request #8852 · facebook/create-react-app](facebook/create-react-app#8852)
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it's intentional or not, but I when I ran my code, TS yelled at me that there was typescript error saying the statement below for
serviceWorker.ts.