Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @typescript-eslint an optional peer dependency #9078

Closed
wants to merge 1 commit into from

Conversation

Vanuan
Copy link

@Vanuan Vanuan commented May 28, 2020

Rebase of #8376

@Vanuan
Copy link
Author

Vanuan commented May 28, 2020

Failures:

Error: [BABEL] .../test-app-typescript/node_modules/react-dev-utils/webpackHotDevClient.js:
 Cannot find module '@babel/helper-create-regexp-features-plugin'
FAIL fixtures/relative-paths/index.test.js (22.146s)
  ● contains a relative path in production build

    TypeError: The "path" argument must be of type string. Received undefinedTypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

       9 | 
      10 |   const buildDir = path.join(testSetup.testDirectory, 'build');
    > 11 |   const cssFile = path.join(
         |                        ^
      12 |     buildDir,
      13 |     globby.sync('**/*.css', { cwd: buildDir }).pop()
      14 |   );

      at Object.<anonymous> (fixtures/relative-paths/index.test.js:11:24)

FAIL fixtures/typescript-advanced/index.test.js (50.918s)
  ● builds in development

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      3 | test('builds in development', async () => {
      4 |   const { fulfilled } = await testSetup.scripts.start({ smoke: true });
    > 5 |   expect(fulfilled).toBe(true);
        |                     ^
      6 | });
      7 | test('builds in production', async () => {
      8 |   const { fulfilled } = await testSetup.scripts.build();

      at Object.<anonymous> (fixtures/typescript-advanced/index.test.js:5:21)
FAIL fixtures/builds-with-multiple-runtimes/index.test.js (24.835s)
  ● builds in development

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      3 | test('builds in development', async () => {
      4 |   const { fulfilled } = await testSetup.scripts.start({ smoke: true });
    > 5 |   expect(fulfilled).toBe(true);
        |                     ^
      6 | });
      7 | test('builds in production', async () => {
      8 |   const { fulfilled } = await testSetup.scripts.build();

      at Object.<anonymous> (fixtures/builds-with-multiple-runtimes/index.test.js:5:21)

builds in production

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

       7 | test('builds in production', async () => {
       8 |   const { fulfilled } = await testSetup.scripts.build();
    >  9 |   expect(fulfilled).toBe(true);
         |                     ^
      10 | });
      11 | 

      at Object.<anonymous> (fixtures/builds-with-multiple-runtimes/index.test.js:9:21)

FAIL fixtures/mjs-support/index.test.js (640.524s)
  ● can use mjs library in development

    : Timeout - Async callback was not invoked within the 300000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 300000ms timeout specified by jest.setTimeout.Error:

      3 | const puppeteer = require('puppeteer');
      4 | 
    > 5 | test('can use mjs library in development', async () => {
        | ^
      6 |   const { port, done } = await testSetup.scripts.start();
      7 | 
      8 |   const browser = await puppeteer.launch({ headless: true });

      at new Spec (../node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Object.<anonymous> (fixtures/mjs-support/index.test.js:5:1)

  ● can use mjs library in production

    : Timeout - Async callback was not invoked within the 300000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 300000ms timeout specified by jest.setTimeout.Error:

      21 |   }
      22 | });
    > 23 | test('can use mjs library in production', async () => {
         | ^
      24 |   await testSetup.scripts.build();
      25 |   const { port, done } = await testSetup.scripts.serve();
      26 | 

      at new Spec (../node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Object.<anonymous> (fixtures/mjs-support/index.test.js:23:1)



@Vanuan Vanuan force-pushed the make-ts-eslint-optional branch 4 times, most recently from 2825976 to 90644c9 Compare May 28, 2020 22:56
@Vanuan Vanuan force-pushed the make-ts-eslint-optional branch 2 times, most recently from 59d3b10 to 0723195 Compare May 28, 2020 23:18
@Vanuan
Copy link
Author

Vanuan commented May 28, 2020

Have no clue what this failure means:

Error: [BABEL] .../test-app-typescript/node_modules/react-dev-utils/webpackHotDevClient.js:
 Cannot find module '@babel/helper-create-regexp-features-plugin'

Maybe some babel dependency was updated

@ianschmitz
Copy link
Contributor

Merge master in and it will fix that error.

@Vanuan
Copy link
Author

Vanuan commented Jun 6, 2020

Apparently, didn't help

@stale
Copy link

stale bot commented Jul 6, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 6, 2020
@Vanuan
Copy link
Author

Vanuan commented Jul 7, 2020

So, is there a way to fix this?

@stale
Copy link

stale bot commented Aug 8, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 16, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants