-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance relayer + documentation (web-vitals) #9116
Add performance relayer + documentation (web-vitals) #9116
Conversation
Hi @housseindjirdeh! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this, but it looks good at an overview, and the docs look great. This is something we definitely talked about getting into the next release - and I'd love to see it make it.
Thoughts @ianschmitz @iansu?
9422416
to
b812d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I think this is good to go 👍
I've tested this on a project today and it works well. Obviously the extension works with or without this, but being able to report on this is really valuable. |
Thanks a ton @housseindjirdeh! Much appreciated. |
Awesome thanks all! So happy to see this land :) |
Fixes #8996
Changes included:
web-vitals
libreportWebVitals
function to index.js template (doesn't do anything until a function is passed in)