-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs & plugin: Add support npm2yarn #9122
base: main
Are you sure you want to change the base?
Conversation
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Can you fix the merge conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR - I really like how bash npm2yarn
simplifies the setup :)
@fanny maybe it's worth publishing the remark-npm2yarn
code (+tests) as an official @docosaurus plugin? I've also noticed that a similar version is currently in use here:
- https://github.com/react-navigation/react-navigation.github.io/blob/main/src/plugins/remark-npm2yarn/index.js
- https://github.com/facebook/docusaurus/blob/master/website/src/plugins/remark-npm2yarn.js
What do you think? Happy to help if you think it's a good idea!
Wow, that's a great idea, I'll work on that. Appreciate your feedback, thanks! |
Implemented here facebook/docusaurus#3469 |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Nice, can we use that here too? |
Hi @fanny! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Show npm and yarn command on website so our docs is more friendly to both package manager users.
I used a naive plugin(by docusaurus) to convert npm commands to yarn.