Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs & plugin: Add support npm2yarn #9122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fanny
Copy link

@fanny fanny commented Jun 7, 2020

Show npm and yarn command on website so our docs is more friendly to both package manager users.

I used a naive plugin(by docusaurus) to convert npm commands to yarn.

image

@fanny fanny requested review from amyrlam and iansu as code owners June 7, 2020 00:31
@fanny fanny changed the title docs: Add support npm2yarn docs & plugin: Add support npm2yarn Jun 7, 2020
@stale
Copy link

stale bot commented Jul 25, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 25, 2020
@nickserv
Copy link
Contributor

Can you fix the merge conflict?

@stale stale bot removed the stale label Jul 25, 2020
Copy link
Contributor

@tobiasbueschel tobiasbueschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR - I really like how bash npm2yarn simplifies the setup :)

@fanny maybe it's worth publishing the remark-npm2yarn code (+tests) as an official @docosaurus plugin? I've also noticed that a similar version is currently in use here:

What do you think? Happy to help if you think it's a good idea!

@amyrlam amyrlam removed their request for review August 24, 2020 05:41
@fanny
Copy link
Author

fanny commented Sep 20, 2020

Wow, that's a great idea, I'll work on that. Appreciate your feedback, thanks!

@fanny
Copy link
Author

fanny commented Sep 21, 2020

Implemented here facebook/docusaurus#3469

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2020
@nickserv
Copy link
Contributor

Nice, can we use that here too?

@stale stale bot removed the stale label Dec 25, 2020
@facebook-github-bot
Copy link

Hi @fanny!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants