Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add definitions for individual env #917

Closed
wants to merge 1 commit into from
Closed

add definitions for individual env #917

wants to merge 1 commit into from

Conversation

thien-do
Copy link
Contributor

@thien-do thien-do commented Oct 17, 2016 •
edited
Loading

Issue: #915

@gaearon
Copy link
Contributor

gaearon commented Oct 18, 2016

Can you please specify how you verified that your changes work?

@fson
Copy link
Contributor

fson commented Oct 23, 2016

Thanks for the PR @dvkndn! However, after testing with the latest version, I found out that the code you contributed in #807 [already behaves correctly, so this change is not needed.

@fson fson closed this Oct 23, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thien-do @gaearon @fson @facebook-github-bot