Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config-react-app): Remove deprecated eslint-plugin-jsx-a1… #9239 #9253

Closed
wants to merge 1 commit into from

Conversation

getspooky
Copy link

[eslint-config-react-app] accessible-emoji rule has been deprecated

@getspooky getspooky changed the title fix(eslint-config-react-app): Remove deprecated eslint-plugin-jsx-a1… fix(eslint-config-react-app): Remove deprecated eslint-plugin-jsx-a1… #9239 Jul 2, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Aug 1, 2020
@iansu iansu removed the stale label Aug 2, 2020
@iansu
Copy link
Contributor

iansu commented Aug 2, 2020

Can you undo all the unrelated formatting changes?

@iansu iansu added this to the 4.0 milestone Aug 2, 2020
@getspooky
Copy link
Author

Hi @iansu i don't understand what do you mean by Can you undo all the unrelated formatting changes?

@iansu iansu linked an issue Aug 2, 2020 that may be closed by this pull request
@iansu
Copy link
Contributor

iansu commented Aug 2, 2020

This file should have a single line changed and instead it has over 70 lines changed and all those extra changes are just changes in formatting. The person who originally reported this issue has created a PR to fix it so I've merged that PR instead. Thanks for your PR.

@iansu iansu closed this Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eslint-config-react-app] accessible-emoji rule has been deprecated
3 participants