Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update importing-a-component.md #9275

Closed
wants to merge 1 commit into from

Conversation

codder-shivam
Copy link

added webpack information

added webpack information
@facebook-github-bot
Copy link

Hi @codder-shivam!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@eddiemonge
Copy link
Contributor

I would actually remove the webpack part since its not customizable and is an implementation detail. Maybe have the line say This project setup supports ES6 modules.

@codder-shivam
Copy link
Author

I would actually remove the webpack part since its not customizable and is an implementation detail. Maybe have the line say This project setup supports ES6 modules.

well yes that's true.... i added only for the one who's interested in understanding the concept of working of underlying libraries and logics.... as i found it little difficult discoovering the logic being a newbie ;) .

btw thanks for the feedback .

@stale
Copy link

stale bot commented Aug 16, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Aug 16, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants