Update adding-typescript.md #9289
Conversation
--save option is default as of npm 5.x
|
Hi @rmacd! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
docusaurus/docs/adding-typescript.md
Outdated
| @@ -26,7 +26,7 @@ yarn create react-app my-app --template typescript | |||
| To add [TypeScript](https://www.typescriptlang.org/) to a Create React App project, first install it: | |||
|
|
|||
| ```sh | |||
| npm install --save typescript @types/node @types/react @types/react-dom @types/jest | |||
| npm install typescript @types/node @types/react @types/react-dom @types/jest | |||
There was a problem hiding this comment.
I think they should actually be dev dependencies so maybe instead add --save-dev?
add as a dev dependency
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
--save option is default as of npm 5.x