Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template name handling #9412

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix template name handling #9412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/create-react-app/__tests__/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"env": {
"jest": true
}
}
82 changes: 82 additions & 0 deletions packages/create-react-app/__tests__/getTemplateInstallPackage.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

const { getTemplateInstallPackage } = require('../createReactApp');

describe('getTemplateInstallPackage', () => {
it('no options gives cra-template', async () => {
await expect(getTemplateInstallPackage()).resolves.toBe('cra-template');
});

it('cra-template gives cra-template', async () => {
await expect(getTemplateInstallPackage('cra-template')).resolves.toBe(
'cra-template'
);
});

it('cra-template-typescript gives cra-template-typescript', async () => {
await expect(getTemplateInstallPackage('cra-template-typescript')).resolves.toBe(
'cra-template-typescript'
);
});

it('typescript gives cra-template-typescript', async () => {
await expect(getTemplateInstallPackage('typescript')).resolves.toBe(
'cra-template-typescript'
);
});

it('typescript@next gives cra-template-typescript@next', async () => {
await expect(getTemplateInstallPackage('cra-template-typescript@next')).resolves.toBe(
'cra-template-typescript@next'
);
});

it('cra-template@next gives cra-template@next', async () => {
await expect(getTemplateInstallPackage('cra-template@next')).resolves.toBe(
'cra-template@next'
);
});

it('cra-template-typescript@next gives cra-template-typescript@next', async () => {
await expect(getTemplateInstallPackage('cra-template-typescript@next')).resolves.toBe(
'cra-template-typescript@next'
);
});

it('@iansu gives @iansu/cra-template', async () => {
await expect(getTemplateInstallPackage('@iansu')).resolves.toBe(
'@iansu/cra-template'
);
});

it('@iansu/cra-template gives @iansu/cra-template', async () => {
await expect(
getTemplateInstallPackage('@iansu/cra-template')
).resolves.toBe('@iansu/cra-template');
});

it('@iansu/cra-template@next gives @iansu/cra-template@next', async () => {
await expect(
getTemplateInstallPackage('@iansu/cra-template@next')
).resolves.toBe('@iansu/cra-template@next');
});

it('@iansu/cra-template-typescript@next gives @iansu/cra-template-typescript@next', async () => {
await expect(getTemplateInstallPackage('@iansu/cra-template-typescript@next')).resolves.toBe(
'@iansu/cra-template-typescript@next'
);
});

it('http://example.com/cra-template.tar.gz gives http://example.com/cra-template.tar.gz', async () => {
await expect(
getTemplateInstallPackage('http://example.com/cra-template.tar.gz')
).resolves.toBe('http://example.com/cra-template.tar.gz');
});
});
Loading