Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memo to SVGR #9423

Closed
wants to merge 1 commit into from
Closed

Add memo to SVGR #9423

wants to merge 1 commit into from

Conversation

vihanb
Copy link

@vihanb vihanb commented Aug 5, 2020

This PR sets the memo: true flag for the SVGR plugin (see issue #9422). I don't exactly understand how the tests are implemented with this mono-repo setup, or how/if I should add/modify them.

Signed-off-by: Vihan vihan+github@vihan.org

Signed-off-by: Vihan <vihan+github@vihan.org>
@facebook-github-bot
Copy link

Hi @vihanb!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Sep 5, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Sep 5, 2020
@vihanb
Copy link
Author

vihanb commented Sep 5, 2020

Could a maintainer review/provide feedback on this PR?

@stale stale bot removed the stale label Sep 5, 2020
@stale
Copy link

stale bot commented Oct 11, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Oct 11, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants