Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency installation versions #9528

Closed
wants to merge 1 commit into from
Closed

Conversation

Dru89
Copy link

@Dru89 Dru89 commented Aug 24, 2020

This updates the dependency installation versions to match the versions for the peer dependencies in the package.json.

Specifically:

  • @typescript-eslint dependencies are now 3.x (up from 2.x)
  • eslint is now 7.x (previously 6.x)
  • eslint-plugin-flowtype is not 5.x (previously 4.x)
  • and eslint-plugin-react-hooks is now at 4.x (up from 2.x)

This updates the dependency installation versions to match the versions for the peer dependencies in the `package.json`.

Specifically: 
* `@typescript-eslint` dependencies are now `3.x` (up from `2.x`)
* `eslint` is now `7.x` (previously `6.x`)
* `eslint-plugin-flowtype` is not `5.x` (previously `4.x`)
* and `eslint-plugin-react-hooks` is now at `4.x` (up from `2.x`)
@facebook-github-bot
Copy link

Hi @Dru89!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Dru89
Copy link
Author

Dru89 commented Aug 28, 2020

Hmm, I'm realizing that package.json says 5.2.1 (released in March), but the actual packages in there are for the "latest" version of eslint-config-react-app which hasn't yet been released.

Perhaps we shouldn't update the README.md with these versions until we actually do a release with the latest changes.

@mrmckeb mrmckeb closed this Sep 12, 2020
@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 12, 2020

Sorry, I commented on the wrong PR.

This is covered by #9434 already, so I've closed this one off @Dru89 - thanks for your time though.

@Dru89
Copy link
Author

Dru89 commented Sep 13, 2020

Ha, no problem! Thanks for the response and letting me know. 😄

@Dru89 Dru89 deleted the patch-1 branch September 13, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants