-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added info on using global variables. #976
Conversation
@@ -542,6 +543,20 @@ Please refer to these two threads for reference: | |||
|
|||
Create React App will add decorator support when the specification advances to a stable stage. | |||
|
|||
## Using Global Variables defined elsewhere | |||
|
|||
When you include a script in the HTML file that defines global variables, and you then try to use one of these variables in code managed by Create React Aapp, ESLint will complain because it cannot see the definition of the variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: typo "Aapp" -> "App"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Maybe add this section right after "public folder" section? |
Done. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! |
* Added info on using global variables. See issue facebook#972. * Fixed typo. * Moved new section. * Small tweaks * Syntax highlighting
* Added info on using global variables. See issue facebook#972. * Fixed typo. * Moved new section. * Small tweaks * Syntax highlighting
* Added info on using global variables. See issue facebook#972. * Fixed typo. * Moved new section. * Small tweaks * Syntax highlighting
See issue #972.