Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info on using global variables. #976

Merged
merged 5 commits into from
Nov 20, 2016
Merged

Conversation

jhorneman
Copy link
Contributor

See issue #972.

@@ -542,6 +543,20 @@ Please refer to these two threads for reference:

Create React App will add decorator support when the specification advances to a stable stage.

## Using Global Variables defined elsewhere

When you include a script in the HTML file that defines global variables, and you then try to use one of these variables in code managed by Create React Aapp, ESLint will complain because it cannot see the definition of the variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: typo "Aapp" -> "App"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@gaearon
Copy link
Contributor

gaearon commented Oct 28, 2016

Maybe add this section right after "public folder" section?

@jhorneman
Copy link
Contributor Author

Done.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit 61b123d into facebook:master Nov 20, 2016
@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

Thanks!

jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
* Added info on using global variables.

See issue facebook#972.

* Fixed typo.

* Moved new section.

* Small tweaks

* Syntax highlighting
@fson fson added this to the 0.8.0 milestone Dec 3, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Added info on using global variables.

See issue facebook#972.

* Fixed typo.

* Moved new section.

* Small tweaks

* Syntax highlighting
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Added info on using global variables.

See issue facebook#972.

* Fixed typo.

* Moved new section.

* Small tweaks

* Syntax highlighting
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants