Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: React is not defined compilation error after ejected #9885

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

n3tr
Copy link
Contributor

@n3tr n3tr commented Oct 24, 2020

fix #9882

Eject the app will cause React is not defined, This is due to the Babel's configuration for JSX runtime gets removed during ejecting.

Change

  • Keep runtime configuration on ejection

Verify Steps

  • yarn create-react-app test-ejecting-app
  • cd test-eject-app
  • yarn eject
  • yarn start and app should gets compiled successfully

@ehsankhfr
Copy link
Contributor

@n3tr Seems the change is already done by another PR and is merged.

@ianschmitz ianschmitz changed the title [v4] Fix React is not defined compilation error after ejected fix: React is not defined compilation error after ejected Oct 26, 2020
@ianschmitz ianschmitz added this to the 4.0.1 milestone Oct 26, 2020
@ianschmitz ianschmitz merged commit 027b03b into facebook:master Oct 26, 2020
@ianschmitz
Copy link
Contributor

Thanks for the fixes @n3tr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4]ReferenceError: React is not defined
4 participants