Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the usage of react-jsx-source & react-jsx-self #992

Merged
merged 2 commits into from
Nov 17, 2016
Merged

Explain the usage of react-jsx-source & react-jsx-self #992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
240fa11
Clears the usage of react-jsx-source & react-jsx-self
sathishsoundharajan Oct 30, 2016
562e8fb
Tweak wording
gaearon Nov 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/babel-preset-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ if (env !== 'development' && env !== 'test' && env !== 'production') {
}

if (env === 'development' || env === 'test') {
// The following two plugins are currently necessary to make React warnings
// include more valuable information. They are included here because they are
// currently not enabled in babel-preset-react. See the below threads for more info:
// https://github.com/babel/babel/issues/4702
// https://github.com/babel/babel/pull/3540#issuecomment-228673661
// https://github.com/facebookincubator/create-react-app/issues/989
plugins.push.apply(plugins, [
// Adds component stack to warning messages
require.resolve('babel-plugin-transform-react-jsx-source'),
Expand Down Expand Up @@ -99,4 +105,3 @@ if (env === 'test') {
// ]);
}
}