Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sass-loader #9988

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Upgrade sass-loader #9988

merged 1 commit into from
Dec 8, 2020

Conversation

ehsankhfr
Copy link
Contributor

@ehsankhfr ehsankhfr commented Nov 2, 2020 •
edited
Loading

Fix #9986
With the current node-sass version (v5), react-script won't survive.

TEST PLAN

With the sass-loader version upgrade and new version of node-sass:

  1. npx create-react-app sass-error-compilation
  2. cd sass-error-compilation
  3. yarn add node-sass@5.0.0
  4. Modify App.css to App.scss. Change extension in App.js as well.
  5. change the sass-loader version in node_modules/react-scripts/package.json to ^10.0.5
  6. yarn add sass-loader@10.0.5
  7. yarn start
  8. Should work successfully

With the sass-loader version upgrade and old version of node-sass:

  1. npx create-react-app sass-error-compilation
  2. cd sass-error-compilation
  3. yarn add node-sass@4.14.1
  4. Modify App.css to App.scss. Change extension in App.js as well.
  5. change the sass-loader version in node_modules/react-scripts/package.json to ^10.0.5
  6. yarn add sass-loader@10.0.5
  7. yarn start
  8. Should work successfully

Without the version upgrade and and new version of node-sass:

  1. npx create-react-app sass-error-compilation
  2. cd sass-error-compilation
  3. yarn add node-sass@5.0.0
  4. Modify App.css to App.scss. Change extension in App.js as well.
  5. yarn start
  6. Should fail to run with version incompatibility error

@ehsankhfr ehsankhfr changed the title Fix #9986 Fix: Upgrading outdated sass-loader Nov 2, 2020
@pranitcode

This comment has been minimized.

Sign in to view
@ianschmitz ianschmitz added this to the 4.0.2 milestone Dec 8, 2020
@ianschmitz ianschmitz changed the title Fix: Upgrading outdated sass-loader Upgrade sass-loader Dec 8, 2020
@ianschmitz ianschmitz merged commit 6dce3f4 into facebook:master Dec 8, 2020
@JackHowa JackHowa mentioned this pull request Dec 9, 2020
Closed
JackHowa added a commit to JackHowa/create-react-app that referenced this pull request Dec 9, 2020
@JackHowa
Update docs before milestone release 4.0.2
3bbfc8d 
Encountered this issue after following instructions. saw issue sass/node-sass#3016 and recent fix facebook#9988
@JackHowa JackHowa mentioned this pull request Dec 9, 2020
Closed
@ehsankhfr ehsankhfr deleted the ISSUE-9986-sass-loader-upgrade branch January 19, 2021 16:20
@0xdevalias 0xdevalias mentioned this pull request Jan 25, 2021
Closed
5 tasks
@drich7449 drich7449 mentioned this pull request Feb 23, 2021
Open
@hzhz hzhz mentioned this pull request Feb 23, 2021
Open
@sirinartk sirinartk mentioned this pull request Feb 23, 2021
Closed
blackarctic added a commit to blackarctic/create-react-app that referenced this pull request Apr 29, 2021
@blackarctic @ryota-murakami
@KonstantinSimeonov @iansu @sho-t @anyulled @ianschmitz @jeffposnick @EvanBacon @trainto @sheepsteak @jasonwilliams @jabranr @jrr @raix @maxsbelt @ehsankhfr @merceyz @Avivhdr @tobiasbueschel @josezone @mad-jose @ajhyndman @mrmckeb @jamesgeorge007 @Awarua- @wclem4
Align with react-scripts 4.0.3 (#17)
109f05d 
* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921)

Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com>

* Add logo license to README

* Remove trailing space in reportWebVitals.ts (facebook#10040)

* docs: add React Testing Library as a library requiring jsdom (facebook#10052)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048)

* Create FUNDING.yml

* replace inquirer with prompts (facebook#10083)

- remove `react-dev-utils/inquirer` public import

* Prepare 4.0.1 release

* Prepare 4.0.1 release

* Publish

 - cra-template-typescript@1.1.1
 - cra-template@1.1.1
 - create-react-app@4.0.1
 - react-dev-utils@11.0.1
 - react-scripts@4.0.1

* chore: bump web-vital dependency version (facebook#10143)

* chore: bump typescript version (facebook#10141)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

* remove chalk from formatWebpackMessages (facebook#10198)

* Upgrade @svgr/webpack to fix build error (facebook#10213)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Improve vendor chunk names in development (facebook#9569)

* Update postcss packages (facebook#10003)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Recovered some integration tests (facebook#10091)

* Upgrade sass-loader (facebook#9988)

* Move ESLint cache file into node_modules (facebook#9977)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

* Revert "Update postcss packages" (facebook#10216)

This reverts commit 580ed5d.

* Remove references to Node 8 (facebook#10214)

* fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872)

* Update using-the-public-folder.md (facebook#10314)

Some library --> Some libraries

* docs: add missing override options for Jest config (facebook#9473)

* Fix CI tests (facebook#10217)

* appTsConfig immutability handling by immer (facebook#10027)

Co-authored-by: mad-jose <joset@yeswearemad.com>

* Add support for new BUILD_PATH advanced configuration variable (facebook#8986)

* Add opt-out for eslint-webpack-plugin (facebook#10170)

* Prepare 4.0.2 release

* Publish

 - cra-template-typescript@1.1.2
 - cra-template@1.1.2
 - create-react-app@4.0.2
 - react-dev-utils@11.0.2
 - react-error-overlay@6.0.9
 - react-scripts@4.0.2

* tests: update test case to match the description (facebook#10384)

* Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312)

Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs

* Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590)

* update immer to 8.0.1 to address vulnerability (facebook#10412)

Resolves facebook#10411

Bumps immer version to 8.0.1 to address the prototype pollution
vulnerability with the current 7.0.9 version.

* Prepare 4.0.3 release

* Update CHANGELOG

* Publish

 - create-react-app@4.0.3
 - react-dev-utils@11.0.3
 - react-scripts@4.0.3

Co-authored-by: Ryota Murakami <dojce1048@gmail.com>
Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com>
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
Co-authored-by: sho90 <aznecosann@gmail.com>
Co-authored-by: Anyul Rivas <anyulled@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Jeffrey Posnick <jeffy@google.com>
Co-authored-by: Evan Bacon <baconbrix@gmail.com>
Co-authored-by: Sahil Purav <sahil5684@gmail.com>
Co-authored-by: Hakjoon Sim <trainto@gmail.com>
Co-authored-by: Chris Shepherd <chris@chrisshepherd.me>
Co-authored-by: Jason Williams <936006+jasonwilliams@users.noreply.github.com>
Co-authored-by: Jabran Rafique⚡️ <jabranr@users.noreply.github.com>
Co-authored-by: John Ruble <johnruble@gmail.com>
Co-authored-by: Morten N.O. Nørgaard Henriksen <morten.n.o.henriksen@icloud.com>
Co-authored-by: Sergey Makarov <serega.s.makar@gmail.com>
Co-authored-by: EhsanKhaki <ehsankhfr@gmail.com>
Co-authored-by: Kristoffer K <merceyz@users.noreply.github.com>
Co-authored-by: Aviv Hadar <Avivhdr@gmail.com>
Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com>
Co-authored-by: mad-jose <44253495+josezone@users.noreply.github.com>
Co-authored-by: mad-jose <joset@yeswearemad.com>
Co-authored-by: Andrew Hyndman <ajhyndman@hotmail.com>
Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: Dion Woolley <woolley.dion@gmail.com>
Co-authored-by: Walker Clem <51654951+wclem4@users.noreply.github.com>
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@ehsankhfr @wombleton
Upgrade sass-loader (facebook#9988)
ec48b33
@BenJenkinson BenJenkinson mentioned this pull request Jun 29, 2021
Open
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
@ehsankhfr @abhiisheek
Upgrade sass-loader (facebook#9988)
347cbf9
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@ehsankhfr @abhiisheek
Upgrade sass-loader (facebook#9988)
cdb96da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: underlying tools
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

node-sass v5.0.0 compilation error
4 participants
@ehsankhfr @pranitcode @ianschmitz @facebook-github-bot