fix(v2): fix plugin-ideal-image breaking website (exports not defined)

facebook · Dec 1, 2019 · 005c684 · 005c684
1 parent 464d8e5
commit 005c684
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 42 deletions.
diff --git a/packages/docusaurus-plugin-ideal-image/@types/react-ideal-image.d.ts b/packages/docusaurus-plugin-ideal-image/@types/react-ideal-image.d.ts
diff --git a/packages/docusaurus-plugin-ideal-image/copyUntypedFiles.js b/packages/docusaurus-plugin-ideal-image/copyUntypedFiles.js
@@ -0,0 +1,19 @@
+/**
+ * Copyright (c) 2017-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+const path = require('path');
+const fs = require('fs-extra');
+
+/**
+ * Copy all untyped and static assets files to lib.
+ */
+const srcDir = path.resolve(__dirname, 'src');
+const libDir = path.resolve(__dirname, 'lib');
+fs.copySync(srcDir, libDir, {
+  filter(filepath) {
+    return !/__tests__/.test(filepath) && !/\.ts$/.test(filepath);
+  },
+});
diff --git a/packages/docusaurus-plugin-ideal-image/package.json b/packages/docusaurus-plugin-ideal-image/package.json
@@ -4,7 +4,7 @@
   "description": "Docusaurus Plugin to generate an almost ideal image (responsive, lazy-loading, and low quality placeholder)",
   "main": "lib/index.js",
   "scripts": {
-    "tsc": "tsc"
+    "tsc": "tsc && node copyUntypedFiles.js"
   },
   "publishConfig": {
     "access": "public"
@@ -17,6 +17,7 @@
     "@endiliey/lqip-loader": "^3.0.2",
     "@endiliey/react-ideal-image": "^0.0.11",
     "@endiliey/responsive-loader": "^1.3.2",
+    "fs-extra": "^8.1.0",
     "react-waypoint": "^9.0.2",
     "sharp": "^0.22.1"
   },

diff --git a/packages/docusaurus-plugin-ideal-image/src/index.ts b/packages/docusaurus-plugin-ideal-image/src/index.ts
@@ -10,7 +10,7 @@ import {Configuration} from 'webpack';
 
 import path from 'path';
 
-export = function(_context: LoadContext, options: PluginOptions) {
+export default function(_context: LoadContext, options: PluginOptions) {
   const isProd = process.env.NODE_ENV === 'production';
   return {
     name: 'docusaurus-plugin-ideal-image',
@@ -47,4 +47,4 @@ export = function(_context: LoadContext, options: PluginOptions) {
       };
     },
   };
-};
+}
diff --git a/...ugin-ideal-image/src/theme/IdealImage.tsx → ...lugin-ideal-image/src/theme/IdealImage.js b/...ugin-ideal-image/src/theme/IdealImage.tsx → ...lugin-ideal-image/src/theme/IdealImage.js
@@ -4,12 +4,10 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
-
 import React from 'react';
-import {ImageProps} from '../types';
 import IdealImage from '@endiliey/react-ideal-image';
 
-const Image: React.FC<ImageProps> = props => {
+function Image(props) {
   const {alt, className, img} = props;
   return (
     <IdealImage
@@ -20,12 +18,12 @@ const Image: React.FC<ImageProps> = props => {
       width={img.src.width || 100}
       placeholder={{lqip: img.preSrc}}
       src={img.src.src}
-      srcSet={img.src.images.map((image: any) => ({
+      srcSet={img.src.images.map(image => ({
         ...image,
         src: image.path,
       }))}
     />
   );
-};
+}
 
 export default Image;
diff --git a/packages/docusaurus-plugin-ideal-image/src/types.ts b/packages/docusaurus-plugin-ideal-image/src/types.ts
@@ -35,7 +35,3 @@ export interface PluginOptions {
    */
   quality?: number;
 }
-
-export interface ImageProps extends React.ImgHTMLAttributes<{}> {
-  img: any;
-}
diff --git a/packages/docusaurus-plugin-ideal-image/tsconfig.json b/packages/docusaurus-plugin-ideal-image/tsconfig.json
@@ -5,7 +5,5 @@
     "tsBuildInfoFile": "./lib/.tsbuildinfo",
     "rootDir": "src",
     "outDir": "lib",
-    "jsx": "react",
-    "typeRoots": ["@types"],
   }
 }