Address change requests

Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
facebook · Jun 24, 2021 · 269c971 · 269c971
1 parent 4f38010
commit 269c971
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -114,7 +114,7 @@ module.exports = {
     'prefer-destructuring': WARNING,
     yoda: WARNING,
     'no-control-regex': WARNING,
-    'no-empty': WARNING,
+    'no-empty': [WARNING, {allowEmptyCatch: true}],
     'no-prototype-builtins': WARNING,
     'no-case-declarations': WARNING,
     'no-undef': OFF,

diff --git a/packages/docusaurus-plugin-content-docs/src/sidebars.ts b/packages/docusaurus-plugin-content-docs/src/sidebars.ts
@@ -128,7 +128,7 @@ function assertIsCategory(
   }
   // "collapsed" is an optional property
   if (
-    Object.prototype.hasOwnProperty.call(item, 'collapsed') &&
+    typeof item.collapsed !== 'undefined' &&
     typeof item.collapsed !== 'boolean'
   ) {
     throw new Error(

diff --git a/packages/docusaurus/src/server/configValidation.ts b/packages/docusaurus/src/server/configValidation.ts
@@ -116,9 +116,7 @@ const SiteUrlSchema = URISchema.required().custom(function (value, helpers) {
         warningMessage: `the url is not supposed to contain a sub-path like '${pathname}', please use the baseUrl field for sub-paths`,
       });
     }
-  } catch (e) {
-    /* Do nothing with invalid URL */
-  }
+  } catch (e) {}
   return value;
 }, 'siteUrlCustomValidation');