test: fix async tests resolved in random order (#6143)

facebook · Dec 21, 2021 · 2872924 · 2872924
1 parent 9078fd9
commit 2872924
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 31 deletions.
diff --git a/packages/docusaurus-plugin-content-docs/src/__tests__/docs.test.ts b/packages/docusaurus-plugin-content-docs/src/__tests__/docs.test.ts
@@ -468,24 +468,26 @@ describe('simple site', () => {
 
   test('docs with invalid id', async () => {
     const {defaultTestUtils} = await loadSite();
-    expect(() => {
+    await expect(async () =>
       defaultTestUtils.processDocFile(
         createFakeDocFile({
           source: 'some/fake/path',
           frontmatter: {
             id: 'Hello/world',
           },
         }),
-      );
-    }).toThrowErrorMatchingInlineSnapshot(
+      ),
+    ).rejects.toThrowErrorMatchingInlineSnapshot(
       `"Document id \\"Hello/world\\" cannot include slash."`,
     );
   });
 
   test('custom pagination', async () => {
     const {defaultTestUtils, options, versionsMetadata} = await loadSite();
     const docs = await readVersionDocs(versionsMetadata[0], options);
-    expect(await defaultTestUtils.generateNavigation(docs)).toMatchSnapshot();
+    await expect(
+      defaultTestUtils.generateNavigation(docs),
+    ).resolves.toMatchSnapshot();
   });
 
   test('bad pagination', async () => {
@@ -497,9 +499,9 @@ describe('simple site', () => {
         frontmatter: {pagination_prev: 'nonexistent'},
       }),
     );
-    await expect(async () => {
-      await defaultTestUtils.generateNavigation(docs);
-    }).rejects.toThrowErrorMatchingInlineSnapshot(
+    await expect(
+      defaultTestUtils.generateNavigation(docs),
+    ).rejects.toThrowErrorMatchingInlineSnapshot(
       `"Error when loading hehe in .: the pagination_prev front matter points to a non-existent ID nonexistent."`,
     );
   });

diff --git a/website/docs/using-themes.md b/website/docs/using-themes.md
@@ -247,27 +247,3 @@ These lifecycle methods are not essential but recommended:
 
 - [`validateThemeConfig({themeConfig, validate})`](./api/plugin-methods/static-methods.md#validateThemeConfig)
 - [`validateOptions({options, validate})`](./api/plugin-methods/static-methods.md#validateOptions)
-
-<!--
-
-Outline
----
-High-level overview about themes:
-- how to use a theme
-- how to pass theme configurations
-- how to swizzle components and the power of it
-
-Related pieces
----
-
-- [Advanced Guides – Themes](using-themes.md)
-- [Lifecycle APIs](./api/lifecycle-apis.md)
-
-References
----
-- [themes RFC](https://github.com/facebook/docusaurus/issues/1438)
-- [how classic template uses themes](/packages/docusaurus/templates/classic/docusaurus.config.js)
-- [using plugins doc](using-plugins.md)
-- [vuepress docs on themes](https://v1.vuepress.vuejs.org/theme/)
-
--->