fix(v2): fix cannot import css from node_modules in userland (#1463)

facebook · May 16, 2019 · 5685e8a · 5685e8a
1 parent e873c14
commit 5685e8a
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 86 deletions.
diff --git a/packages/docusaurus/package.json b/packages/docusaurus/package.json
@@ -72,8 +72,7 @@
     "webpack-bundle-analyzer": "^3.1.0",
     "webpack-dev-server": "^3.2.1",
     "webpack-merge": "^4.1.4",
-    "webpack-nicelog": "^2.3.1",
-    "webpack-node-externals": "^1.7.2"
+    "webpack-nicelog": "^2.3.1"
   },
   "peerDependencies": {
     "react": "^16.8.4",

diff --git a/packages/docusaurus/src/client/PendingNavigation.js b/packages/docusaurus/src/client/PendingNavigation.js
@@ -9,7 +9,7 @@ import React from 'react';
 import {Route, withRouter} from 'react-router-dom';
 import nprogress from 'nprogress';
 import preload from './preload';
-import './nprogress.css';
+import 'nprogress/nprogress.css';
 
 nprogress.configure({showSpinner: false});
 

diff --git a/packages/docusaurus/src/client/nprogress.css b/packages/docusaurus/src/client/nprogress.css
diff --git a/packages/docusaurus/src/webpack/server.js b/packages/docusaurus/src/webpack/server.js
@@ -5,7 +5,6 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-const nodeExternals = require('webpack-node-externals');
 const path = require('path');
 const StaticSiteGeneratorPlugin = require('static-site-generator-webpack-plugin');
 const WebpackNiceLog = require('webpack-nicelog');
@@ -37,8 +36,6 @@ module.exports = function createServerConfig(props) {
       globalObject: 'this',
     },
     target: 'node',
-    // No need to bundle its node_modules dependencies since we're bundling for static html generation (backend)
-    externals: [nodeExternals()],
     plugins: [
       // Wait until manifest from client bundle is generated
       new WaitPlugin({

diff --git a/yarn.lock b/yarn.lock
@@ -13946,11 +13946,6 @@ webpack-nicelog@^2.3.1:
     react-dev-utils "^5.0.1"
     webpackbar "^2.6.1"
 
-webpack-node-externals@^1.7.2:
-  version "1.7.2"
-  resolved "https://registry.yarnpkg.com/webpack-node-externals/-/webpack-node-externals-1.7.2.tgz#6e1ee79ac67c070402ba700ef033a9b8d52ac4e3"
-  integrity sha512-ajerHZ+BJKeCLviLUUmnyd5B4RavLF76uv3cs6KNuO8W+HuQaEs0y0L7o40NQxdPy5w0pcv8Ew7yPUAQG0UdCg==
-
 webpack-sources@^0.2.0:
   version "0.2.3"
   resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-0.2.3.tgz#17c62bfaf13c707f9d02c479e0dcdde8380697fb"