PR review changes

facebook · Dec 21, 2019 · 69cbf5c · 69cbf5c
1 parent ed1704d
commit 69cbf5c
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.js b/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.js
@@ -13,7 +13,7 @@ import Clipboard from 'clipboard';
 import rangeParser from 'parse-numeric-range';
 import useDocusaurusContext from '@docusaurus/useDocusaurusContext';
 import useTheme from '@theme/hooks/useTheme';
-import useEventBus from '@docusaurus/useEventBus';
+import useEventBus from '@theme/hooks/useEventBus';
 import styles from './styles.module.css';
 
 const highlightLinesRangeRegex = /{([\d,-]+)}/;
@@ -29,11 +29,12 @@ export default ({children, className: languageClassName, metastring}) => {
   const button = useRef(null);
   let highlightLines = [];
   const [theme] = useTheme();
-  const [prismTheme, setPrismTheme] = useState(defaultTheme);
+  const lightThemePrism = prism.theme || defaultTheme;
+  const [prismTheme, setPrismTheme] = useState(lightThemePrism);
   const changePrismTheme = newTheme =>
     prism.darkTheme && newTheme === 'dark'
       ? setPrismTheme(prism.darkTheme)
-      : setPrismTheme(defaultTheme);
+      : setPrismTheme(lightThemePrism);
 
   if (metastring && highlightLinesRangeRegex.test(metastring)) {
     const highlightLinesRange = metastring.match(highlightLinesRangeRegex)[1];

diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/index.js b/packages/docusaurus-theme-classic/src/theme/Navbar/index.js
@@ -9,7 +9,6 @@ import React, {useCallback, useState} from 'react';
 import Link from '@docusaurus/Link';
 import useDocusaurusContext from '@docusaurus/useDocusaurusContext';
 import useBaseUrl from '@docusaurus/useBaseUrl';
-import {dispatch} from '@docusaurus/useEventBus';
 
 import SearchBar from '@theme/SearchBar';
 import Toggle from '@theme/Toggle';
@@ -18,6 +17,7 @@ import classnames from 'classnames';
 
 import useTheme from '@theme/hooks/useTheme';
 import useHideableNavbar from '@theme/hooks/useHideableNavbar';
+import {dispatch} from '@theme/hooks/useEventBus';
 
 import styles from './styles.module.css';
 

diff --git a/...usaurus/src/client/exports/useEventBus.js → ...me-classic/src/theme/hooks/useEventBus.js b/...usaurus/src/client/exports/useEventBus.js → ...me-classic/src/theme/hooks/useEventBus.js
diff --git a/packages/docusaurus-theme-live-codeblock/src/theme/CodeBlock/index.js b/packages/docusaurus-theme-live-codeblock/src/theme/CodeBlock/index.js
@@ -13,7 +13,7 @@ import Clipboard from 'clipboard';
 import rangeParser from 'parse-numeric-range';
 import useDocusaurusContext from '@docusaurus/useDocusaurusContext';
 import useTheme from '@theme/hooks/useTheme';
-import useEventBus from '@docusaurus/useEventBus';
+import useEventBus from '@theme/hooks/useEventBus';
 import Playground from '@theme/Playground';
 import styles from './styles.module.css';
 
@@ -36,11 +36,12 @@ export default ({
   const button = useRef(null);
   let highlightLines = [];
   const [theme] = useTheme();
-  const [prismTheme, setPrismTheme] = useState(defaultTheme);
+  const lightThemePrism = prism.theme || defaultTheme;
+  const [prismTheme, setPrismTheme] = useState(lightThemePrism);
   const changePrismTheme = newTheme =>
     prism.darkTheme && newTheme === 'dark'
       ? setPrismTheme(prism.darkTheme)
-      : setPrismTheme(defaultTheme);
+      : setPrismTheme(lightThemePrism);
 
   if (metastring && highlightLinesRangeRegex.test(metastring)) {
     const highlightLinesRange = metastring.match(highlightLinesRangeRegex)[1];

diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
@@ -60,6 +60,7 @@ module.exports = {
   ],
   themeConfig: {
     prism: {
+      theme: require('prism-react-renderer/themes/github'),
       darkTheme: require('prism-react-renderer/themes/dracula'),
     },
     image: 'img/docusaurus.png',