Skip to content

Commit

Permalink
fix(v2): Consistently use require.resolve in official plugins to reso…
Browse files Browse the repository at this point in the history
…lve modules (#2797)

* fix(v2): Use require.resolve to resolve loaders in official plugins

* Use require.resolve to resolve client modules
  • Loading branch information
SamChou19815 authored May 23, 2020
1 parent 78136e7 commit 705f8f3
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/docusaurus-plugin-content-blog/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export default function pluginContentBlog(
const modules = [];

if (options.admonitions) {
modules.push('remark-admonitions/styles/infima.css');
modules.push(require.resolve('remark-admonitions/styles/infima.css'));
}

return modules;
Expand Down Expand Up @@ -396,7 +396,7 @@ export default function pluginContentBlog(
getCacheLoader(isServer),
getBabelLoader(isServer),
{
loader: '@docusaurus/mdx-loader',
loader: require.resolve('@docusaurus/mdx-loader'),
options: {
remarkPlugins,
rehypePlugins,
Expand Down
4 changes: 2 additions & 2 deletions packages/docusaurus-plugin-content-docs/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default function pluginContentDocs(
const modules = [];

if (options.admonitions) {
modules.push('remark-admonitions/styles/infima.css');
modules.push(require.resolve('remark-admonitions/styles/infima.css'));
}

return modules;
Expand Down Expand Up @@ -522,7 +522,7 @@ export default function pluginContentDocs(
getCacheLoader(isServer),
getBabelLoader(isServer),
{
loader: '@docusaurus/mdx-loader',
loader: require.resolve('@docusaurus/mdx-loader'),
options: {
remarkPlugins,
rehypePlugins,
Expand Down
4 changes: 2 additions & 2 deletions packages/docusaurus-plugin-ideal-image/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ export default function (_context: LoadContext, options: PluginOptions) {
{
test: /\.(png|jpe?g|gif)$/i,
use: [
'@docusaurus/lqip-loader',
require.resolve('@docusaurus/lqip-loader'),
{
loader: '@endiliey/responsive-loader',
loader: require.resolve('@endiliey/responsive-loader'),
options: {
emitFile: !isServer, // don't emit for server-side rendering
disable: !isProd,
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-bootstrap/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = function () {
return path.resolve(__dirname, './theme');
},
getClientModules() {
return ['bootstrap/dist/css/bootstrap.min.css'];
return [require.resolve('bootstrap/dist/css/bootstrap.min.css')];
},
};
};
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module.exports = function (context, options) {

getClientModules() {
const modules = [
'infima/dist/css/default/default.css',
require.resolve('infima/dist/css/default/default.css'),
path.resolve(__dirname, './prism-include-languages'),
];

Expand Down

0 comments on commit 705f8f3

Please sign in to comment.