Updating to 3.2 breaks tailwind integration in production #10005

razzeee · 2024-04-01T14:33:48Z

Have you read the Contributing Guidelines on issues?

I have read the Contributing Guidelines on issues.

Prerequisites

I'm using the latest version of Docusaurus.
I have tried the npm run clear or yarn clear command.
I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
I have tried creating a repro with https://new.docusaurus.io.
I have read the console error message carefully (if applicable).

Description

Upgrading to 3.2 broke the tailwind styling, which I've integrated according to https://medium.com/@bargadyahmed/docusaurus-a-guide-to-seamless-integration-with-tailwind-css-dd202211caac

Here I've added the banner-preview with the custom tailwind integration flathub-infra/documentation@e0dc841 (#272)

It still works fine in dev, but breaks in prod or locally - if I do yarn build and then yarn serve. Unfortunatly the production errors are not helpful.

Basically https://docs.flathub.org/banner-preview/ should be styled. Like this:

Reproducible demo

https://github.com/flathub-infra/documentation

Steps to reproduce

Checkout repo
Run yarn
Run yarn build
Run yarn serve
Goto http://localhost:3000/banner-preview

Expected behavior

The page should be styled like in the above image

Actual behavior

The page isn't styled, presumably because tailwind isn't working, after upgrading to 3.2

Your environment

Public source code: https://github.com/flathub-infra/documentation
Public site URL: https://docs.flathub.org/
Docusaurus version used: 3.2
Environment name and version (e.g. Chrome 89, Node.js 16.4): Shouldn't apply as it's run on github
Operating system and version (e.g. Ubuntu 20.04.2 LTS): Shouldn't apply as it's run on github

Self-service

I'd be willing to fix this bug myself.

The text was updated successfully, but these errors were encountered:

Arhell · 2024-04-01T21:39:13Z

more example
open-feature/openfeature.dev#489

Airkro · 2024-04-02T02:49:39Z

When using v3.2.0, plugins.configurePostCss(options) api not work anymore, maybe is the reason.

SJFCS · 2024-04-02T04:52:29Z

I had the same problem when I upgraded to version 3.2 that will lost tailwind css style after npm build, I look forward to a solution to this problem

OzakIOne · 2024-04-02T20:53:31Z

~~I don't have any problem with Docusaurus V3 in this sandbox following this guide~~

~~https://stackblitz.com/edit/github-fvf5eb?file=src%2Fpages%2Findex.js~~

See my comment below

Arhell · 2024-04-02T21:12:21Z

I don't have any problem with Docusaurus V2 in this sandbox following this guide

https://stackblitz.com/edit/github-fvf5eb?file=src%2Fpages%2Findex.js

Thanks for the example, but it’s not very clear why everything works in the https://openfeature.dev/ version. https://github.com/open-feature/openfeature.dev/blob/main/docusaurus.config.ts#L279

And after updating the dependencies there are no open-feature/openfeature.dev#489

Although, as mentioned above, everything works locally, but in production, alas. https://deploy-preview-489--openfeature.netlify.app/

Arhell · 2024-04-02T21:13:00Z

and this is for all projects where I updated dependencies yesterday
AvaloniaUI/avalonia-docs#436
openyurtio/openyurt.io#405

and everyone has the same problem, locally everything is fine, production is not

OzakIOne · 2024-04-02T21:19:54Z

Oops my bad, I forgot after trying to reproduce with the base guide the problem is in production

Indeed I have the same error in the sandbox with version 3.2.0 and no issue in version 3.1.0 i'll try to take a look

3.2.0 sanbox dev no issue, prod issue

3.1.0 sandbox dev and prod no issue

slorber · 2024-04-02T22:04:56Z

Thanks for reporting, it's probably a mistake I did when refactoring things to improve performance.

I'll take a look soon and publish a fix ASAP.

heysokam · 2024-04-03T17:13:02Z

@slorber I've seen people report that the bug doesn't trigger on v3.1.0
Whatever broke it, it also fails in the same way with v3.1.1
I went back in history in my repository to a commit that I knew for a fact it worked, removed cache and node_modules to start fresh, and the bug still triggers
In fact, it started triggering with that version running without updating to 3.2.0

~~edit1:~~
~~It might be me calling the old repository by accident. I'm double checking, sorry~~
~~Will edit this comment again after confirming.~~

Edit2: Nope, nvm. It is triggering in v3.1.1 indeed
I removed, specifically, /build, /.docusaurus, /node_modules and package-lock.json to start fresh, and it still triggers.
A teammate tested on their computer, which had not updated since a long time ago, or reset anything, and they don't trigger the issue. We are trying to find why that is the case.

Edit3: It was triggering in ^3.1.1 specifically, which installed 3.2.0 for a reason unknown to our team. See my next comment.

heysokam · 2024-04-03T19:33:13Z

Update: We were on ^3.1.1, but it was rounding up to 3.2.0 on install.
So false alarm, it triggers on v3.2.0, and works correctly in v3.1.0

slorber · 2024-04-04T11:04:48Z

Can you please test canary 0.0.0-5886?
https://docusaurus.io/community/canary

It is the same as v3.2 (no breaking change, but this problem should be fixed)

Arhell · 2024-04-04T11:52:31Z

Can you please test canary 0.0.0-5886? https://docusaurus.io/community/canary

It is the same as v3.2 (no breaking change, but this problem should be fixed)

I checked it on all the projects that I support, everything works, only the one had problems with the plugin https://www.npmjs.com/package/docusaurus-plugin-image-zoom

but I think this is not a problem, I deleted it and everything worked, most likely it does not support the canary version or there is another problem.

Thanks for the work.

razzeee · 2024-04-04T12:12:00Z

Canary seems to work for me too - but I also had to remove a dependency, cause it was expecting a docusaurus version bigger then 3.0

slorber · 2024-04-04T12:29:14Z

Great 👍

I'll release soon

everything works, only the one had problems with the plugin npmjs.com/package/docusaurus-plugin-image-zoom

Maybe worth opening an issue on that plugin repo. I can't help if I don't know what the problem was.

Canary seems to work for me too - but I also had to remove a dependency, cause it was expecting a docusaurus version bigger then 3.0

Which dependency? Which version are you upgrading from? 2.x?

razzeee · 2024-04-04T12:37:23Z

Canary seems to work for me too - but I also had to remove a dependency, cause it was expecting a docusaurus version bigger then 3.0

Which dependency? Which version are you upgrading from? 2.x?

Docusaurus 3.2 to the canary

Dependency is docusaurus-plugin-search-local

Probably caused by https://github.com/gabrielcsapo/docusaurus-plugin-search-local/blob/main/package.json#L97

Cause it breaks Tailwind CSS support facebook/docusaurus#10005

slorber · 2024-04-04T13:17:51Z

Ah, I see yes, it might prevent you from using a canary due to the 0.0.0 versions. I will try to figure out a solution to improve this.

slorber · 2024-04-04T17:49:04Z

Fix released in v3.2.1

https://github.com/facebook/docusaurus/releases/tag/v3.2.1

#### Motivation and context Fix the CSS issue introduced by docusaurus 3.2.0 (facebook/docusaurus#10005). 3.2.1 should fix it but the affected version maybe loaded by dependencies, so we will have to wait a bit more.   ### Checklist - [ ] The change come with new or modified tests - [x] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change --------- Co-authored-by: Natoandro <anatoandro@hotmail.com>

razzeee added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 1, 2024

OzakIOne closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024

OzakIOne added closed: can't repro This bug is because of some local setup that can't be reproduced. and removed bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 2, 2024

OzakIOne reopened this Apr 2, 2024

OzakIOne added bug An error in the Docusaurus core causing instability or issues with its execution and removed closed: can't repro This bug is because of some local setup that can't be reproduced. labels Apr 2, 2024

This was referenced Apr 3, 2024

[devops] fix: change version until docu 3.2 is fixed ir-engine/ir-engine-docs#160

Merged

[devops] chg: Update Docusaurus to v3.2.0 ir-engine/ir-engine-docs#159

Closed

slorber mentioned this issue Apr 4, 2024

fix(core): fix configurePostCss v3.2 regression #10012

Merged

slorber closed this as completed in #10012 Apr 4, 2024

gregberge added a commit to argos-ci/docs that referenced this issue Apr 4, 2024

chore: downgrade from v3.2.0 to v3.1.1

8ac770d

Cause it breaks Tailwind CSS support facebook/docusaurus#10005

zifeo mentioned this issue Apr 23, 2024

fix: website and headline metatypedev/metatype#691

Merged

3 tasks

huacnlee mentioned this issue Apr 25, 2024

Upgrade Docusaurus v3.x longportapp/openapi-website#253

Draft

2 tasks

shadowusr mentioned this issue May 4, 2024

Updating past 3.1.1 breaks postCSS plugins customisation. Fully debugged, just needs fixing #10106

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating to 3.2 breaks tailwind integration in production #10005

Updating to 3.2 breaks tailwind integration in production #10005

razzeee commented Apr 1, 2024

Arhell commented Apr 1, 2024

Airkro commented Apr 2, 2024

SJFCS commented Apr 2, 2024

OzakIOne commented Apr 2, 2024 •

edited

Loading

Arhell commented Apr 2, 2024

Arhell commented Apr 2, 2024 •

edited

Loading

OzakIOne commented Apr 2, 2024 •

edited

Loading

slorber commented Apr 2, 2024

heysokam commented Apr 3, 2024 •

edited

Loading

heysokam commented Apr 3, 2024

slorber commented Apr 4, 2024

Arhell commented Apr 4, 2024

razzeee commented Apr 4, 2024

slorber commented Apr 4, 2024 •

edited

Loading

razzeee commented Apr 4, 2024 •

edited

Loading

slorber commented Apr 4, 2024

slorber commented Apr 4, 2024 •

edited

Loading

Updating to 3.2 breaks tailwind integration in production #10005

Updating to 3.2 breaks tailwind integration in production #10005

Comments

razzeee commented Apr 1, 2024

Have you read the Contributing Guidelines on issues?

Prerequisites

Description

Reproducible demo

Steps to reproduce

Expected behavior

Actual behavior

Your environment

Self-service

Arhell commented Apr 1, 2024

Airkro commented Apr 2, 2024

SJFCS commented Apr 2, 2024

OzakIOne commented Apr 2, 2024 • edited Loading

Arhell commented Apr 2, 2024

Arhell commented Apr 2, 2024 • edited Loading

OzakIOne commented Apr 2, 2024 • edited Loading

slorber commented Apr 2, 2024

heysokam commented Apr 3, 2024 • edited Loading

heysokam commented Apr 3, 2024

slorber commented Apr 4, 2024

Arhell commented Apr 4, 2024

razzeee commented Apr 4, 2024

slorber commented Apr 4, 2024 • edited Loading

razzeee commented Apr 4, 2024 • edited Loading

slorber commented Apr 4, 2024

slorber commented Apr 4, 2024 • edited Loading

OzakIOne commented Apr 2, 2024 •

edited

Loading

Arhell commented Apr 2, 2024 •

edited

Loading

OzakIOne commented Apr 2, 2024 •

edited

Loading

heysokam commented Apr 3, 2024 •

edited

Loading

slorber commented Apr 4, 2024 •

edited

Loading

razzeee commented Apr 4, 2024 •

edited

Loading

slorber commented Apr 4, 2024 •

edited

Loading