-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): getFileCommitDate should support log.showSignature=true
#10022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 25, 2024
This was referenced May 26, 2024
This was referenced Aug 12, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
This was referenced Sep 1, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the user shows signatures by default in his config (
git config log.showSignature true
),getFileCommitDate
fails to parse the result because of the extra lines being printed, and the regexp to extract it not being able to process the command output due to the signature lines.Problem reported here: #9954 (comment)
I'm now adding a
RESULT:
prefix so that we only attempt to parse the correct lines, ignore all the others.Also, we don't need signatures to get the result, so I'm also passing
git -c log.showSignature=false log
as an option so that the command can execute faster. If users have signatures turned on, we don't want this function to be 3x slower.Note: I also considered the following command but it's not faster and won't work well with the "age: 'oldest'` option:
Test Plan
Unit tests