-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): TypeCheck website/starter in min/max range of TS versions #10063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
iAdramelk
pushed a commit
to iAdramelk/docusaurus
that referenced
this pull request
Apr 21, 2024
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 25, 2024
This was referenced Aug 12, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
This was referenced Sep 1, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have no tests covering that we keep supporting older versions of TypeScript.
As we upgrade TypeScript on our monorepo, it's easy to be misled and release some libs that are incompatible with former TS versions.
Now we ensure that our website + starter remains compatible with TS 5.1
Note, although v3.0 is supposed to support TS 5.0, I think it never actually worked in practice. I can't get it working and get errors such as:
I suspect this is a bug related to the newly released v5.0 moduleResolution "bundler", but can't be sure. Starting v5.1 it works fine.
Also I think it's not a bad idea to require TS 5.1 in Docusaurus v3, because it permits to use ReactNode instead of
JSX.Element
:https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/#decoupled-type-checking-between-jsx-elements-and-jsx-tag-types
Considering Docusaurus v3 was released after TS 5.1, I suspect it never worked under v5.0 and nobody noticed. So I'll bump the docs to mention v5.1 instead of v5.0 as the minimum version, and will not consider it as a breaking change.
Test Plan
CI