-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fail fast if plugin has no name #10239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
7 tasks
This was referenced Aug 30, 2024
Closed
This was referenced Aug 31, 2024
Open
This was referenced Aug 31, 2024
This was referenced Sep 1, 2024
This was referenced Sep 1, 2024
This was referenced Sep 2, 2024
This was referenced Sep 2, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Docusaurus plugins should always have a name.
Apart from clearly identifying them, it also helps to create a dedicated unique namespace per plugin used for various things (creating json files, looking for i18n files...)
Before Docusaurus 3.4- there were cases where using an "anonymous plugin" worked, but it is only by luck of not implementing lifecycles requiring a name. (see #10203)
And our TS types always assumed a name is there.
For these reasons Docusaurus will now ensure a name is provided. I'll consider it a bugfix and not a breaking change.
Test Plan
unit tests