Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(theme-translations): add more Traditional Chinese(zh-Hant) translations #10257

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pjchender
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Update Traditional Chinese (zh-Hant) translations.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3d43bfe
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6682dcdc091b3a00087f2598
😎 Deploy Preview https://deploy-preview-10257--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 1, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 56 🟢 98 🟢 96 🟢 100 🔴 NaN Report
/docs/installation 🟠 76 🟢 97 🟢 100 🟢 100 🔴 NaN Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 🔴 NaN Report
/blog 🟠 68 🟢 100 🟢 100 🟠 86 🔴 NaN Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 96 🟢 100 🟢 100 🔴 NaN Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 86 🔴 NaN Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 🔴 NaN Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. FWIW, this translation is zh-Hant, not zh-TW, so it's okay to not bias word choices towards Taiwanese, Hong Kong, or any other Chinese variant, but I think this is fine since we use 「部落格」 anyway.

@pjchender
Copy link
Contributor Author

Thanks. FWIW, this translation is zh-Hant, not zh-TW, so it's okay to not bias word choices towards Taiwanese, Hong Kong, or any other Chinese variant, but I think this is fine since we use 「部落格」 anyway.

@Josh-Cena Good point. Thanks for the reminder.

@Josh-Cena Josh-Cena changed the title fix(theme-translation): add more Traditional Chinese(zh-Hant) translations chore(theme-translations): add more Traditional Chinese(zh-Hant) translations Jul 2, 2024
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jul 2, 2024
@Josh-Cena Josh-Cena merged commit d2bb74a into facebook:main Jul 2, 2024
33 checks passed
OzakIOne pushed a commit that referenced this pull request Jul 11, 2024
…slations (#10257)

fix(theme-translation): add more Traditional Chinese(zh-Hant) translation
OzakIOne pushed a commit that referenced this pull request Jul 11, 2024
…slations (#10257)

fix(theme-translation): add more Traditional Chinese(zh-Hant) translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants