Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugin-google-gtag): replace the broken Google Developers links with valid ones #10338

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

bohyunjung
Copy link
Contributor

@bohyunjung bohyunjung commented Jul 25, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

plugin-google-gtag has a broken link in its documentation:

This PR fixes the links for all versions.

+ Also removing a redundant comment with invalid link from the source. #10338 (comment)

plugin-google-analytics has broken links as well, but I left it unchanged since the plugin is deprecated. See #10332 (comment)

Related issues/PRs

Please refer to #10332 (comment).

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 25, 2024
@@ -69,7 +69,6 @@ export default function pluginGoogleGtag(
href: 'https://www.googletagmanager.com',
},
},
// https://developers.google.com/analytics/devguides/collection/gtagjs/#install_the_global_site_tag
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this line because the valid link is already provided in L80.

Copy link

netlify bot commented Jul 25, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 998be8e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66a1c348101bbf0008318756
😎 Deploy Preview https://deploy-preview-10338--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 71 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 55 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 54 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 70 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 25, 2024
@slorber
Copy link
Collaborator

slorber commented Jul 25, 2024

LGTM thanks 👍

@slorber slorber merged commit afa9fcc into facebook:main Jul 25, 2024
36 checks passed
@bohyunjung bohyunjung deleted the fix-broken-google-developers-links branch July 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants