Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): fix algolia search ignore ctrl + F in search input #10342

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Jul 26, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This fixes a UX bug. Ideally it gets fixed upstream I believe, for now I add the downstream hack.

Test Plan

See the testplan in #10333 (comment).

Test links

Deploy preview: https://deploy-preview-10342--docusaurus-2.netlify.app/

Related issues/PRs

Fixes #10333

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 26, 2024
Copy link

netlify bot commented Jul 26, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b85b5d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66a39941baf2f000080997fa
😎 Deploy Preview https://deploy-preview-10342--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 62 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 75 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 68 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@josh-wong
Copy link
Contributor

@mxschmitt I tested your fix in my local environment, and it seems to resolve the issue that I reported in #10333.

Thank you for creating this PR to fix the issue!🙏

@slorber
Copy link
Collaborator

slorber commented Aug 9, 2024

thanks 👍

@slorber slorber merged commit a2e30be into facebook:main Aug 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algolia search modal appears when entering a keyboard shortcut to use a browser's "Find" function
4 participants