-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translations): fix wrong Estonian (et) translations and typos #10344
Conversation
Hi @Gekd! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
LGTM but I don't speak Estonian 😅
Little linting issues
This language has only been added recently. Can you help review it @chirbard please?
packages/docusaurus-theme-translations/locales/et/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/et/theme-live-codeblock.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/et/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments that should be fixed. Everything else looks good to me.
packages/docusaurus-theme-translations/locales/et/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed your comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Gekd thanks We need you to sign the CLA. I can't merge the PR otherwise. |
Signed CLA. |
Pre-flight checklist
Motivation
Fix Estonian default translations.
Related issues/PRs
#3526