Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when forgot to pass in GIT_USER #1035

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

tanhauhau
Copy link
Contributor

@tanhauhau tanhauhau commented Oct 14, 2018

Motivation

Closes #1025

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 14, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 04e6f53

https://deploy-preview-1035--docusaurus-preview.netlify.com

@yangshun yangshun changed the title throw error when forgot to pass in GIT_USER (#1025) fix: throw error when forgot to pass in GIT_USER Oct 14, 2018
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanhauhau! In future you don't have to put the issue number in the commit message, because GitHub automatically adds this PR number to the message when it gets merged and seeing two issue numbers in the message is confusing.

Putting "Closes #XXX" in the PR summary is sufficient. Thanks again!

@yangshun yangshun merged commit 287c487 into facebook:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants