-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add caption to user links #1075
Conversation
created a shared component `Showcase`
Deploy preview for docusaurus-preview ready! Built with commit a23407b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, all existing users site using our showcase component will break because we're removing some classes from lib/static/main.css
. We cannot rename the classes, and can only add new ones. This is a downside of v1 that will be addressed in v2.
@yangshun — Can you give some details about why that's the case? Is that something related to caching? Also, please let me know if I need to update other parts of the PR that are affected by this other than the |
@gtoprak I just realized we met at React Conf! Thanks for your contribution! Hmm it's because |
@yangshun — Yes, thank you for the sticker! I am hoping to have many more contributions in the future too. I've made the updates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better! However we want the logos to be of the same width and height and the captions are just right underneath. In this current implementation the captions are not aligned at all.
I've made the suggested updates, and I did have an off alignment on certain user images. Following two screenshots are how it's looking for me, please let me know if that doesn't reflect what the team is envisioning. @yangshun — Thank you for the ongoing code review as I appreciate it a lot since I am not familiar with the code base, it's really helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very awesome. Thank you!
Thank you @yangshun! |
Created a shared component
Showcase
and updated the usages around the site. Effectsindex
andusers
.Motivation
Fixes #1040.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Clean linter, and visited pages affected.
Related PRs
There was already an open PR #1043 by @mptap, but I've taken a significantly different approach and trying to remove some repetition of code.