-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention about website directory naming #1106
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for docusaurus-preview ready! Built with commit 433cc6c |
@facebook-github-bot I signed the CLA, but I'm not fan of it. I don't even understand why this is required. (I know I'm talking to a bot) |
@docusaurus-bot What is https://deploy-preview-1106--docusaurus-preview.netlify.com about? I mean my change is not included in the preview nor is #1098 that was marge 4 days ago. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Thanks for fixing this!
fixing #1082
Motivation
Documenting undocumented stuff.
Have you read the Contributing Guidelines on pull requests?
Of course.
Test Plan
I just changed documentation, it's valid English and markdown.
Related PRs
No.