Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention about website directory naming #1106

Merged
merged 3 commits into from
Nov 11, 2018
Merged

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Nov 11, 2018

fixing #1082

Motivation

Documenting undocumented stuff.

Have you read the Contributing Guidelines on pull requests?

Of course.

Test Plan

I just changed documentation, it's valid English and markdown.

Related PRs

No.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 11, 2018

Deploy preview for docusaurus-preview ready!

Built with commit 433cc6c

https://deploy-preview-1106--docusaurus-preview.netlify.com

@noraj
Copy link
Contributor Author

noraj commented Nov 11, 2018

@facebook-github-bot I signed the CLA, but I'm not fan of it. I don't even understand why this is required. (I know I'm talking to a bot)

@noraj
Copy link
Contributor Author

noraj commented Nov 11, 2018

@docusaurus-bot What is https://deploy-preview-1106--docusaurus-preview.netlify.com about? I mean my change is not included in the preview nor is #1098 that was marge 4 days ago.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 11, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun changed the title documentation: ability to rename the website folder docs: mention about website directory naming Nov 11, 2018
@yangshun yangshun merged commit 2bf2dfe into facebook:master Nov 11, 2018
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks for fixing this!

@noraj noraj deleted the patch-1 branch May 31, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants