Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1114 static files in blog/assets is not working #1143

Merged
merged 3 commits into from
Dec 7, 2018

Conversation

tsmrachel
Copy link
Contributor

@tsmrachel tsmrachel commented Dec 6, 2018

Motivation

#1114

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

checked that it's working for docs - created docs/assets folder, added image to docs, and placed image in assets folder
image

checked that it's working for blog - created blog/assets folder, added image to blog, and placed image in assets folder

image

Related PRs

N.A.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 6, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Dec 6, 2018

Deploy preview for docusaurus-preview ready!

Built with commit ffc790c

https://deploy-preview-1143--docusaurus-preview.netlify.com

@tsmrachel
Copy link
Contributor Author

will especially appreciate any feedback on how the tests can improved. i.e.
maybe i should move the replaceAssetsLink tests into utils.test instead?
or maybe i should create separate blog fixtures for the replaceAssetsLink in blog.test, instead of reusing the docs fixtures?

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Will include it in v1.6.1

@endiliey
Copy link
Contributor

endiliey commented Dec 7, 2018

Thanks @tsmrachel 😊

@endiliey endiliey merged commit a1e7af7 into facebook:master Dec 7, 2018
const cssnano = require('cssnano');
const autoprefixer = require('autoprefixer');
const postcss = require('postcss');
const path = require('path');
const escapeStringRegexp = require('escape-string-regexp');
const siteConfig = require('../../website/siteConfig.js');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke docusaurus completely, see #1149

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that doesn't look right.

@yangshun @endiliey -- I think we need to fix this or revert this specific diff and push out a hotfix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this PR broke the release. My bad to overlook this. Will release a hotfix in ~1 hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants