refactor: update imagemin and its dependencies #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 7676e68 |
|
This moved it from |
|
/cc @yangshun since the merger is on vacation 🙂 |
|
@SimenB I think because they are not a part of the final output, it just modify the files so yes. I could be wrong. |
|
It's just supposed to minimize the images of docusaursus itself, not those of sites using docusaurus? |
|
No it is supposed to optimize the images of the user as well. I saw what I did here 😅 I can revert it back to be in dependencies then. |
|
Please revert to dependencies. Builds of websites are failing after a clean install. |
|
Submitted, my apologies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I introduced imagemin to compress the images in an earlier versions. Currently the versions used have security issues as noticed by
npm audit.The problem happens because of a dependency on a package called tunnel-agent
Motivation
Getting rid of insecure packages.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run build script and check the output. It should compress the images
Related PRs
#654