Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horizontal overflow in sidebar #1205

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Fix horizontal overflow in sidebar #1205

merged 1 commit into from
Jan 28, 2019

Conversation

BTMPL
Copy link
Contributor

@BTMPL BTMPL commented Jan 27, 2019

When the sidebar is collapsible, a horizontal scrollbar can be seen, e.g.:

https://docusaurus.io/docs/en/installation - https://i.imgur.com/IkrkLrp.png

This is caused by the arrow being rendered outside of the sidebar box.

Motivation

Fix an overflow bug in sidebar.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

The issue is visible in the official documentation. Fix should be visible in the PR preview.

When the sidebar is collapsible, a horizontal scrollbar can be seen, e.g.:

https://docusaurus.io/docs/en/installation - https://i.imgur.com/IkrkLrp.png

This is caused by the arrow being rendered outside of the sidebar box.
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 27, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit c858b8b

https://deploy-preview-1205--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on a Mac machine and don't see the problem. But this is fine since the fix also looks ok on Mac. Thanks!

@yangshun yangshun merged commit 1888e0f into facebook:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants