Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade husky to 1.3.1 #1229

Merged
merged 1 commit into from
Feb 12, 2019
Merged

chore: upgrade husky to 1.3.1 #1229

merged 1 commit into from
Feb 12, 2019

Conversation

yoshinorin
Copy link
Contributor

@yoshinorin yoshinorin commented Feb 11, 2019 •
edited
Loading

Motivation

Upgrade husky 0.14.3 to 1.3.1

I upgraded husky & its hook. Because, husky 1.x need to upgrade existing hooks.
Please see official upgrading document.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

I confirmed run husky when pre-commit like below.

husky > pre-commit (node v10.13.0)
25lRunning tasks for v1/**/*.js [started]
Running tasks for v2/**/*.js [started]
Running tasks for v1/**/*.js [skipped]
→ No staged files match v1/**/*.js
Running tasks for v2/**/*.js [skipped]
→ No staged files match v2/**/*.js

Related PRs

Nothing.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 11, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit e032a7e

https://deploy-preview-1229--docusaurus-preview.netlify.com

yangshun
yangshun approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yoshinorin!

@yangshun yangshun merged commit db62233 into facebook:master Feb 12, 2019
@yoshinorin yoshinorin deleted the bump-husky branch February 12, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshinorin @docusaurus-bot @yangshun @facebook-github-bot