fix: css break when hover algolia logo #1240
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-preview ready! Built with commit 8341fca |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks for the PR! While this fix works, it's not very scalable as we hardcode algolia's classname in the CSS and there's no guarantee the name won't change or new elements will be added by Algolia. I think the better fix is to enforce the styling only applies to direct children of li by doing li > a.
|
@yangshun updated, thanks. |
|
@yangshun @endiliey can we release a new version? thanks. related bug: all-contributors/all-contributors#206 |
Motivation
fixes #1239
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)