feat(v2): presets #1401
Merged
feat(v2): presets #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
commented
Apr 27, 2019
| } | ||
| return new Plugin(options, context); | ||
| return new Plugin(context, options); |
There was a problem hiding this comment.
Changing the order here as context is a mandatory parameter but options isn't.
|
Deploy preview for docusaurus-2 ready! Built with commit 0792577 |
|
Deploy preview for docusaurus-preview ready! Built with commit 0792577 |
endiliey
approved these changes
Apr 27, 2019
| throw new Error(`Error loading '${name}' plugin.`); | ||
| } | ||
| // eslint-disable-next-line global-require, import/no-dynamic-require | ||
| Plugin = require(name); |
There was a problem hiding this comment.
I forgot that we have import-fresh. can we do it here ?
| let preset; | ||
| if (presetModule && fs.existsSync(presetModule)) { | ||
| // eslint-disable-next-line global-require, import/no-dynamic-require | ||
| preset = require(presetModule); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow plugins to be bundled as presets. The idea is simple. Each preset is like a mini config, and exposes an array of plugins. When loading the config, we simply concat all of them together and derive a final list of plugins.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Site builds. This change is backward-compatible since the existing tests which aren't using plugins still pass.
I'll add tests for this later (but before merging) after we've agreed on this API.
Related PRs
NA.