fix: enable live reloading title of doc #1507
Conversation
|
Deploy preview for docusaurus-2 ready! Built with commit d6ddcee |
|
Deploy preview for docusaurus-preview ready! Built with commit d6ddcee |
There was a problem hiding this comment.
Please rebase. And also, don't just reload when title is changed. I think we should also reload for other metadata cases :)
For example
https://docusaurus.io/docs/en/doc-markdown#markdown-headers
hide_title and sidebar_label
…fix-live-reload-doc-title # Conflicts: # packages/docusaurus-1.x/lib/server/server.js
@endiliey Made the changes 👍 Now it reloads on |
|
Hey, @endiliey I just realized that I did a |
|
@tusharf5 Merging is fine, the more important thing is you have the latest code within your branch. |
|
@endiliey I've pushed the changes that you suggested. : ) |
|
did u test it out again ? im on vacation so my response is slow |
|
Oh okay : ) and yeah I've tested it out, it works as expected. (live reloads for the specified metadata attributes) @endiliey |
|
ok. lets ship it. 🔥🔥 u ready ? 👀 |
|
Thank you : ) |
|
Nah, thanks to you as the contributor😛👍 |
* fix: enable live reloading title of doc * fix: removing unnecessary reload statements * fix: only title change should trigger a live reload * fix: adding more properties that triggers a live reload * fix: refactoring
Motivation
Fix enable live reloading when doc title is changed #1213
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Local Testing. The blog is working locally after changes without any errors or warnings.
Demo Video Before Changes
Demo Video After Changes
Related PRs
N.A