fix: remove the Container component from the docsNavContainer
#1599
Conversation
In this case, the `docsNavContainer` does not pick up any styles or attributes from the `container` component it is wrapped in. It does however pick up the pesky `.container` className, which when paired with bootstrap, messes up the styling of the top navigation in mobile. This change is completely non-destructive, but helps enable the use of bootstrap on top of Docusaurus.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-2 ready! Built with commit 892cc1a |
|
Deploy preview for docusaurus-preview ready! Built with commit 892cc1a |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
yangshun
changed the title
Container component from the docsNavContainerContainer component from the docsNavContainer
In this case, the
docsNavContainerdoes not pick up any styles or attributes from thecontainercomponent it is wrapped in.It does however pick up the pesky
.containerclassName, which when paired with bootstrap, messes up the styling of the top navigation in mobile.This change is completely non-destructive, but helps enable the use of bootstrap on top of Docusaurus.