Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix Rendering of <AUTOGENERATED_TABLE_OF_CONTENTS> Tag on API -… #1617

Merged
merged 1 commit into from
Jul 12, 2019
Merged

docs: Fix Rendering of <AUTOGENERATED_TABLE_OF_CONTENTS> Tag on API -… #1617

merged 1 commit into from
Jul 12, 2019

Conversation

dhurlburtusa
Copy link
Contributor

For some strange reason, the first use of `<AUTOGENERATED_TABLE_OF_CONTENTS>` in the "Generating Table of Contents" section renders as two backticks.

autogenerated_table_of_contents_tag_treated_like_mark_up-docusaurus_site

but the second use is rendered as expected.

I searched through the entire document to see if there was a missing or an extraneous backtick anywhere. I didn't find anything wrong (maybe I missed something).

The GitHub preview renders correctly before and after this PR.

autogenerated_table_of_contents_tag_treated_like_mark_up-github_preview

So, I am not sure what the best way to fix this is. Seems to be a bug in the markdown parser used by Docusaurus or some other bug.

Motivation

Markup not rendering on the site as expected.

Have you read the Contributing Guidelines on pull requests?

For Docusaurus: no. For React: yes.

Test Plan

Without cloning and building the Docusaurus site locally, I don't have a plan since GitHub's preview shows everything is fine but after building and deploying the site, the markdown was not translated correctly.

I am hoping a maintainer might see an alternative solution I can implement instead of using the HACK I used. If not, then I'll go to the extra length to build locally to see if a better solution is available.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 20, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d79cb4e

https://deploy-preview-1617--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit d79cb4e

https://deploy-preview-1617--docusaurus-preview.netlify.com

@dhurlburtusa
Copy link
Contributor Author

Hmm, the https://deploy-preview-1617--docusaurus-preview.netlify.com doesn't seem to contain the changes. Along with the HACK, I also had some whitespace fixes in the "Language-specific Code Tabs" section which are not showing up in the deploy-preview. Maybe I am misunderstanding the purpose of the deploy preview.

@endiliey
Copy link
Contributor

endiliey commented Jul 4, 2019

Docs change is only done on /next version of docs.

@endiliey endiliey merged commit 684a246 into facebook:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants